shufflingpixels/php-io
1
0
Fork 0
mirror of https://github.com/shufflingpixels/php-io.git synced 2026-08-15 19:58:14 +02:00
Code Activity

Remove BinaryReader stream and string helpers

Browse source 
BinaryReader does not own the stream object. so we should not have a
method that creates one (string) also remove stream() as its the same as
the constructor.
This commit is contained in:
Henrik Hautakoski 2026-06-26 13:24:20 +02:00
parent 0fa93d691c
commit 785e48a023
3 changed files with 14 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/Unit/LimitedResourceTest.php
View file

@ -302,7 +302,7 @@ it('integrates with BinaryReader for binary reads from a scoped section', functi
$buffer = new Buffer($data);
$limited = new LimitedResource($buffer, 4, 4);
$reader = BinaryReader::stream($limited);
$reader = new BinaryReader($limited);
expect($reader->length())->toBe(4)
->and($reader->readUInt32LE())->toBe($value);
@ -314,7 +314,7 @@ it('BinaryReader seek works within the window', function () {
$buffer = new Buffer($data);
$limited = new LimitedResource($buffer, 8, 4);
$reader = BinaryReader::stream($limited);
$reader = new BinaryReader($limited);
$first = $reader->readUInt32LE();
$reader->seek(0);