From 03cbba9a6c152b465ce0d8664715168c463f7f74 Mon Sep 17 00:00:00 2001 From: Henrik Hautakoski Date: Sat, 10 Sep 2022 14:10:11 +0200 Subject: [PATCH] include/Spectre/Core/NonCopyable.h: Destructor needs to be virtual. Otherwise deleting a NonCopyable pointer wont call the child class destructor --- include/Spectre/Core/NonCopyable.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/Spectre/Core/NonCopyable.h b/include/Spectre/Core/NonCopyable.h index 3eb8210..5efd853 100644 --- a/include/Spectre/Core/NonCopyable.h +++ b/include/Spectre/Core/NonCopyable.h @@ -9,7 +9,7 @@ class NonCopyable protected : NonCopyable() = default; - ~NonCopyable() = default; + virtual ~NonCopyable() = default; // Delete Copy constructor and assignment. NonCopyable(const NonCopyable&) = delete;