pnx/neotest-phpunit
1
0
Fork 0
mirror of https://github.com/pnx/neotest-phpunit synced 2026-07-03 11:43:40 +02:00
Code Releases Activity

Fix issue with tests that start with "it"

Browse source
This commit is contained in:
Michael Utz 2022-11-16 17:11:56 +03:00
parent 6e04f7b2e7
commit c017340679
2 changed files with 138 additions and 380 deletions
Download patch file Download diff file Expand all files Collapse all files

3
lua/neotest-pest/utils.lua
View file

@ -57,8 +57,9 @@ end
local function make_outputs(test, output_file) local function make_outputs(test, output_file)
logger.info("Pre-output test:", test) logger.info("Pre-output test:", test)
local test_attr = test["_attr"] or test[1]["_attr"] local test_attr = test["_attr"] or test[1]["_attr"]
local name = string.gsub(test_attr.name, "it (.*)", "%1")
local test_id = test_attr.file .. separator .. test_attr.name local test_id = test_attr.file .. separator .. name
logger.info("Pest id:", { test_id }) logger.info("Pest id:", { test_id })
local test_output = { local test_output = {

457
specs/utils_spec.lua
View file

@ -1,407 +1,164 @@
local utils = require("neotest-phpunit.utils") local utils = require("neotest-pest.utils")
describe("get_test_results", function() describe("get_test_results", function()
it("parses output when testing a method", function() it("parses output with whole file", function()
local output_file = "/tmp/nvimhYaIPj/3" local output_file = "/tmp/nvimhYaIPj/3"
local xml_output = { local xml_output = {
testsuites = { testsuites = {
testsuite = { testsuite = {
_attr = { _attr = {
assertions = "1", assertions = "17",
errors = "0", errors = "0",
failures = "0", failures = "0",
file = "/Users/Oli/Code/Projects/neotest-phpunit/tests/Unit/ExampleTest.php",
name = "ExampleTest",
skipped = "0",
tests = "1",
time = "0.002292",
warnings = "0",
},
testcase = {
_attr = {
assertions = "1",
class = "ExampleTest",
classname = "ExampleTest",
file = "/Users/Oli/Code/Projects/neotest-phpunit/tests/Unit/ExampleTest.php",
line = "7",
name = "test_that_true_is_true",
time = "0.002292",
},
},
},
},
}
local expected = {
["/Users/Oli/Code/Projects/neotest-phpunit/tests/Unit/ExampleTest.php::7"] = {
["output_file"] = "/tmp/nvimhYaIPj/3",
["short"] = [[EXAMPLETEST
-> PASSED - test_that_true_is_true]],
["status"] = "passed",
},
}
assert.are.same(utils.get_test_results(xml_output, output_file), expected)
end)
it("parses output when testing a file", function()
local output_file = "/tmp/nvimhYaIPj/3"
local xml_output = {
testsuites = {
testsuite = {
_attr = {
assertions = "2",
errors = "0",
failures = "0",
file = "/Users/Oli/Code/Projects/neotest-phpunit/tests/Examples/UserTest.php",
name = "TestProject\\UserTest",
skipped = "0",
tests = "2",
time = "0.001525",
warnings = "0",
},
testcase = {
{
_attr = {
assertions = "3",
class = "TestProject\\UserTest",
classname = "TestProject.UserTest",
file = "/Users/Oli/Code/Projects/neotest-phpunit/tests/Examples/UserTest.php",
line = "13",
name = "testClassConstructor",
time = "0.000949",
},
},
{
_attr = {
assertions = "2",
class = "TestProject\\UserTest",
classname = "TestProject.UserTest",
file = "/Users/Oli/Code/Projects/neotest-phpunit/tests/Examples/UserTest.php",
line = "22",
name = "testTellName",
time = "0.000135",
},
},
},
},
},
}
local expected = {
["/Users/Oli/Code/Projects/neotest-phpunit/tests/Examples/UserTest.php::13"] = {
["output_file"] = "/tmp/nvimhYaIPj/3",
["short"] = [[TESTPROJECT.USERTEST
-> PASSED - testClassConstructor]],
["status"] = "passed",
},
["/Users/Oli/Code/Projects/neotest-phpunit/tests/Examples/UserTest.php::22"] = {
["output_file"] = "/tmp/nvimhYaIPj/3",
["short"] = [[TESTPROJECT.USERTEST
-> PASSED - testTellName]],
["status"] = "passed",
},
}
assert.are.same(utils.get_test_results(xml_output, output_file), expected)
end)
it("parses a file even if there is a failure", function()
local output_file = "/tmp/nvimhYaIPj/3"
local xml_output = {
testsuites = {
testsuite = {
_attr = {
assertions = "2",
errors = "0",
failures = "1",
file = "/Users/Oli/Code/Projects/neotest-phpunit/tests/Unit/ExampleTest.php",
name = "ExampleTest",
skipped = "0",
tests = "2",
time = "0.001008",
warnings = "0",
},
testcase = {
{
_attr = {
assertions = "1",
class = "ExampleTest",
classname = "ExampleTest",
file = "/Users/Oli/Code/Projects/neotest-phpunit/tests/Unit/ExampleTest.php",
line = "12",
name = "test_that_false_is_true",
time = "0.000141",
},
failure = {
[[ExampleTest::test_that_false_is_true
Failed asserting that false is true.
/Users/Oli/Code/Projects/neotest-phpunit/tests/Unit/ExampleTest.php:14]],
_attr = {
type = "PHPUnit\\Framework\\ExpectationFailedException",
},
},
},
},
},
},
}
local expected = {
["/Users/Oli/Code/Projects/neotest-phpunit/tests/Unit/ExampleTest.php::12"] = {
errors = {
{
line = "12",
},
},
output_file = "/tmp/nvimhYaIPj/3",
status = "failed",
},
}
assert.are.same(utils.get_test_results(xml_output, output_file), expected)
end)
it("parses multiple files", function()
local output_file = "/tmp/nvimhYaIPj/3"
local xml_output = {
testsuites = {
testsuite = {
_attr = {
assertions = "18",
errors = "0",
failures = "1",
name = "", name = "",
skipped = "0", skipped = "0",
tests = "8", tests = "7",
time = "0.001904", time = "0.006846",
warnings = "0", warnings = "0"
}, },
testsuite = { testsuite = { {
{
_attr = {
assertions = "2",
errors = "0",
failures = "1",
name = "Unit",
skipped = "0",
tests = "2",
time = "0.001233",
warnings = "0",
},
testsuite = {
_attr = {
assertions = "2",
errors = "0",
failures = "1",
file = "/Users/Oli/Code/Projects/neotest-phpunit/tests/Unit/ExampleTest.php",
name = "ExampleTest",
skipped = "0",
tests = "2",
time = "0.001233",
warnings = "0",
},
testcase = {
{
_attr = { _attr = {
assertions = "1", assertions = "1",
class = "ExampleTest",
classname = "ExampleTest",
file = "/Users/Oli/Code/Projects/neotest-phpunit/tests/Unit/ExampleTest.php",
line = "7",
name = "test_that_true_is_true",
time = "0.001027",
},
},
{
_attr = {
assertions = "1",
class = "ExampleTest",
classname = "ExampleTest",
file = "/Users/Oli/Code/Projects/neotest-phpunit/tests/Unit/ExampleTest.php",
line = "13",
name = "this_should_fail",
time = "0.000207",
},
failure = {
[[ExampleTest::this_should_fail
Failed asserting that false is true.
/Users/Oli/Code/Projects/neotest-phpunit/tests/Unit/ExampleTest.php:15]],
_attr = {
type = "PHPUnit\\Framework\\ExpectationFailedException",
},
},
},
},
},
},
{
_attr = {
assertions = "16",
errors = "0", errors = "0",
failures = "0", failures = "0",
name = "Examples", file = "/Users/michaelutz/Code/neotest-pest/tests/Examples/some/deep/nesting/NestingTest.php",
name = "P\\Tests\\Examples\\some\\deep\\nesting\\NestingTest",
skipped = "0", skipped = "0",
tests = "6", tests = "1",
time = "0.000671", time = "0.002344",
warnings = "0", warnings = "0"
}, },
testsuite = { testcase = {
{ _attr = {
assertions = "1",
class = "Tests\\Examples\\some\\deep\\nesting\\NestingTest",
classname = "Tests.Examples.some.deep.nesting.NestingTest",
file = "/Users/michaelutz/Code/neotest-pest/tests/Examples/some/deep/nesting/NestingTest.php",
name = "is true",
time = "0.002344"
}
}
}, {
_attr = { _attr = {
assertions = "15", assertions = "15",
errors = "0", errors = "0",
failures = "0", failures = "0",
file = "/Users/Oli/Code/Projects/neotest-phpunit/tests/Examples/UserTest.php", file = "/Users/michaelutz/Code/neotest-pest/tests/Feature/UserTest.php",
name = "TestProject\\UserTest", name = "P\\Tests\\Feature\\UserTest",
skipped = "0", skipped = "0",
tests = "5", tests = "5",
time = "0.000646", time = "0.004385",
warnings = "0", warnings = "0"
}, },
testcase = { testcase = { {
{
_attr = { _attr = {
assertions = "3", assertions = "3",
class = "TestProject\\UserTest", class = "Tests\\Feature\\UserTest",
classname = "TestProject.UserTest", classname = "Tests.Feature.UserTest",
file = "/Users/Oli/Code/Projects/neotest-phpunit/tests/Examples/UserTest.php", file = "/Users/michaelutz/Code/neotest-pest/tests/Feature/UserTest.php",
line = "13", name = "class constructor",
name = "testClassConstructor", time = "0.000941"
time = "0.000145", }
}, }, {
},
{
_attr = { _attr = {
assertions = "2", assertions = "2",
class = "TestProject\\UserTest", class = "Tests\\Feature\\UserTest",
classname = "TestProject.UserTest", classname = "Tests.Feature.UserTest",
file = "/Users/Oli/Code/Projects/neotest-phpunit/tests/Examples/UserTest.php", file = "/Users/michaelutz/Code/neotest-pest/tests/Feature/UserTest.php",
line = "22", name = "tellName",
name = "testTellName", time = "0.000494"
time = "0.000143", }
}, }, {
},
{
_attr = { _attr = {
assertions = "2", assertions = "2",
class = "TestProject\\UserTest", class = "Tests\\Feature\\UserTest",
classname = "TestProject.UserTest", classname = "Tests.Feature.UserTest",
file = "/Users/Oli/Code/Projects/neotest-phpunit/tests/Examples/UserTest.php", file = "/Users/michaelutz/Code/neotest-pest/tests/Feature/UserTest.php",
line = "30", name = "can tellAge",
name = "testTellAge", time = "0.000384"
time = "0.000026", }
}, }, {
},
{
_attr = { _attr = {
assertions = "3", assertions = "3",
class = "TestProject\\UserTest", class = "Tests\\Feature\\UserTest",
classname = "TestProject.UserTest", classname = "Tests.Feature.UserTest",
file = "/Users/Oli/Code/Projects/neotest-phpunit/tests/Examples/UserTest.php", file = "/Users/michaelutz/Code/neotest-pest/tests/Feature/UserTest.php",
line = "38", name = "addFavoriteMovie",
name = "testAddFavoriteMovie", time = "0.000959"
time = "0.000149", }
}, }, {
},
{
_attr = { _attr = {
assertions = "5", assertions = "5",
class = "TestProject\\UserTest", class = "Tests\\Feature\\UserTest",
classname = "TestProject.UserTest", classname = "Tests.Feature.UserTest",
file = "/Users/Oli/Code/Projects/neotest-phpunit/tests/Examples/UserTest.php", file = "/Users/michaelutz/Code/neotest-pest/tests/Feature/UserTest.php",
line = "47", name = "removeFavoriteMovie",
name = "testRemoveFavoriteMovie", time = "0.001608"
time = "0.000183", }
}, } }
}, }, {
},
},
{
_attr = { _attr = {
assertions = "1", assertions = "1",
errors = "0", errors = "0",
failures = "0", failures = "0",
file = "/Users/Oli/Code/Projects/neotest-phpunit/tests/Examples/some/deep/nesting/NestingTest.php", file = "/Users/michaelutz/Code/neotest-pest/tests/Unit/ExampleTest.php",
name = "NestingTest", name = "P\\Tests\\Unit\\ExampleTest",
skipped = "0", skipped = "0",
tests = "1", tests = "1",
time = "0.000025", time = "0.000116",
warnings = "0", warnings = "0"
}, },
testcase = { testcase = {
_attr = { _attr = {
assertions = "1", assertions = "1",
class = "NestingTest", class = "Tests\\Unit\\ExampleTest",
classname = "NestingTest", classname = "Tests.Unit.ExampleTest",
file = "/Users/Oli/Code/Projects/neotest-phpunit/tests/Examples/some/deep/nesting/NestingTest.php", file = "/Users/michaelutz/Code/neotest-pest/tests/Unit/ExampleTest.php",
line = "7", name = "example",
name = "test_something_that_is_true", time = "0.000116"
time = "0.000025", }
}, }
}, } }
}, }
}, }
},
},
},
},
} }
local expected = { local expected = {
["/Users/Oli/Code/Projects/neotest-phpunit/tests/Examples/UserTest.php::13"] = { ["/Users/michaelutz/Code/neotest-pest/tests/Examples/some/deep/nesting/NestingTest.php::is true"] = {
output_file = "/tmp/nvimhYaIPj/3", output_file = output_file,
short = [[TESTPROJECT.USERTEST short = "TESTS.EXAMPLES.SOME.DEEP.NESTING.NESTINGTEST\n-> PASSED - is true",
-> PASSED - testClassConstructor]], status = "passed"
status = "passed",
}, },
["/Users/Oli/Code/Projects/neotest-phpunit/tests/Examples/UserTest.php::22"] = { ["/Users/michaelutz/Code/neotest-pest/tests/Feature/UserTest.php::addFavoriteMovie"] = {
output_file = "/tmp/nvimhYaIPj/3", output_file = output_file,
short = [[TESTPROJECT.USERTEST short = "TESTS.FEATURE.USERTEST\n-> PASSED - addFavoriteMovie",
-> PASSED - testTellName]], status = "passed"
status = "passed",
}, },
["/Users/Oli/Code/Projects/neotest-phpunit/tests/Examples/UserTest.php::30"] = { ["/Users/michaelutz/Code/neotest-pest/tests/Feature/UserTest.php::can tellAge"] = {
output_file = "/tmp/nvimhYaIPj/3", output_file = output_file,
short = [[TESTPROJECT.USERTEST short = "TESTS.FEATURE.USERTEST\n-> PASSED - can tellAge",
-> PASSED - testTellAge]], status = "passed"
status = "passed",
}, },
["/Users/Oli/Code/Projects/neotest-phpunit/tests/Examples/UserTest.php::38"] = { ["/Users/michaelutz/Code/neotest-pest/tests/Feature/UserTest.php::class constructor"] = {
output_file = "/tmp/nvimhYaIPj/3", output_file = output_file,
short = [[TESTPROJECT.USERTEST short = "TESTS.FEATURE.USERTEST\n-> PASSED - class constructor",
-> PASSED - testAddFavoriteMovie]], status = "passed"
status = "passed",
}, },
["/Users/Oli/Code/Projects/neotest-phpunit/tests/Examples/UserTest.php::47"] = { ["/Users/michaelutz/Code/neotest-pest/tests/Feature/UserTest.php::removeFavoriteMovie"] = {
output_file = "/tmp/nvimhYaIPj/3", output_file = output_file,
short = [[TESTPROJECT.USERTEST short = "TESTS.FEATURE.USERTEST\n-> PASSED - removeFavoriteMovie",
-> PASSED - testRemoveFavoriteMovie]], status = "passed"
status = "passed",
}, },
["/Users/Oli/Code/Projects/neotest-phpunit/tests/Examples/some/deep/nesting/NestingTest.php::7"] = { ["/Users/michaelutz/Code/neotest-pest/tests/Feature/UserTest.php::tellName"] = {
output_file = "/tmp/nvimhYaIPj/3", output_file = output_file,
short = [[NESTINGTEST short = "TESTS.FEATURE.USERTEST\n-> PASSED - tellName",
-> PASSED - test_something_that_is_true]], status = "passed"
status = "passed",
},
["/Users/Oli/Code/Projects/neotest-phpunit/tests/Unit/ExampleTest.php::13"] = {
errors = {
{
line = "13",
},
},
output_file = "/tmp/nvimhYaIPj/3",
status = "failed",
},
["/Users/Oli/Code/Projects/neotest-phpunit/tests/Unit/ExampleTest.php::7"] = {
output_file = "/tmp/nvimhYaIPj/3",
short = [[EXAMPLETEST
-> PASSED - test_that_true_is_true]],
status = "passed",
}, },
["/Users/michaelutz/Code/neotest-pest/tests/Unit/ExampleTest.php::example"] = {
output_file = output_file,
short = "TESTS.UNIT.EXAMPLETEST\n-> PASSED - example",
status = "passed"
}
} }
assert.are.same(utils.get_test_results(xml_output, output_file), expected) assert.are.same(utils.get_test_results(xml_output, output_file), expected)