From 30fa9f7ed80be3552c59fdb0fb9e20b147820849 Mon Sep 17 00:00:00 2001 From: Koichi Shiraishi Date: Fri, 24 May 2019 19:56:52 +0900 Subject: [PATCH] uri: change Parse arg to s instead of uri --- uri.go | 4 ++-- uri_test.go | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/uri.go b/uri.go index 8d5529d..47fab95 100644 --- a/uri.go +++ b/uri.go @@ -104,8 +104,8 @@ type State struct { } // Parse parses and creates a new URI from uri. -func Parse(uri string) *URI { - u, err := url.Parse(uri) +func Parse(s string) *URI { + u, err := url.Parse(s) if err != nil { panic(fmt.Sprintf("url.Parse: %#v\n", err)) } diff --git a/uri_test.go b/uri_test.go index 0bea378..da745e1 100644 --- a/uri_test.go +++ b/uri_test.go @@ -16,12 +16,12 @@ import ( func TestParse(t *testing.T) { tests := []struct { name string - uri string + s string want *uri.URI }{ { name: "Valid", - uri: "https://code.visualstudio.com/docs/extensions/overview#frag", + s: "https://code.visualstudio.com/docs/extensions/overview#frag", want: &uri.URI{ Scheme: "https", Authority: "code.visualstudio.com", @@ -35,7 +35,7 @@ func TestParse(t *testing.T) { t.Run(tt.name, func(t *testing.T) { t.Parallel() - if diff := cmp.Diff(uri.Parse(tt.uri), tt.want); diff != "" { + if diff := cmp.Diff(uri.Parse(tt.s), tt.want); diff != "" { t.Errorf("%s: (-got, +want)\n%s", tt.name, diff) } })