3 commits

Author	SHA1	Message	Date
Keegan Carruthers-Smith	5d80b29f44	conn: do not lock sending when closing (#70) ... The sending mutex may be blocked due to the underlying conn blocking. If that happens then we can't call close since close also attempts to hold the sending mutex. Sending mutex is only used for serializing sends and doesn't protect the fields close reads/writes. I believe we introduced locking it so we would return ErrClosed. This commit instead introduces a check in send which rechecks if we have since closed while attempting to send. Test Plan: expanded the test coverage	2023-06-07 08:40:20 +02:00
Sam Herrmann	ae88a5e7c0	Always omit params member from request when empty (#67) ... With this commit, the JSON encoding of `Request` always omits the params member when calling `Conn.Call`, `Conn.DispatchCall`, or `Conn.Notify` with the `params` argument set to `nil`. This change also removes the `OmitNilParams` call option that was added in commit 8012d496 (#62). As of this commit, if users desire to send a JSON-RPC request with a `params` value of `null`, then they may do so by explicitly setting the `params` argument of `Conn.Call`/`Conn.DispatchCall`/`Conn.Notify` to `json.RawMessage("null")`.	2023-02-22 10:53:44 +02:00
Sam Herrmann	846c29e96d	Split jsonrpc2.go file into multiple files (#65) ... This merge request moves some of the contents from the jsonrpc2.go file into their own designated file. The new files being introduced (excluding test files) are as follows: * conn.go * request.go * response.go The motive of this change is to make it easier to navigate the code. Without this change, the jsonrpc2.go file is 813 lines of code.	2023-02-09 07:56:42 +01:00