From 81af42d766d4b9e2f4b87b154a1221ef213e938b Mon Sep 17 00:00:00 2001 From: s3rj1k Date: Thu, 7 Nov 2019 23:44:16 +0200 Subject: [PATCH] minor logging fixes Signed-off-by: s3rj1k --- conn_opt.go | 2 +- handler_with_error.go | 4 ++-- object_test.go | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/conn_opt.go b/conn_opt.go index 00c10e7..3779d7f 100644 --- a/conn_opt.go +++ b/conn_opt.go @@ -43,7 +43,7 @@ func LogMessages(logger Logger) ConnOpt { OnRecv(func(req *Request, resp *Response) { switch { - case req != nil && resp == nil: + case req != nil: mu.Lock() reqMethods[req.ID] = req.Method mu.Unlock() diff --git a/handler_with_error.go b/handler_with_error.go index 3feaf09..2bd5c1d 100644 --- a/handler_with_error.go +++ b/handler_with_error.go @@ -21,7 +21,7 @@ func (h *HandlerWithErrorConfigurer) Handle(ctx context.Context, conn *Conn, req result, err := h.handleFunc(ctx, conn, req) if req.Notif { if err != nil { - conn.logger.Printf("jsonrpc2 handler: notification %q handling error: %s\n", req.Method, err) + conn.logger.Printf("jsonrpc2 handler: notification %q handling error: %v\n", req.Method, err) } return } @@ -41,7 +41,7 @@ func (h *HandlerWithErrorConfigurer) Handle(ctx context.Context, conn *Conn, req if !req.Notif { if err := conn.SendResponse(ctx, resp); err != nil { if err != ErrClosed || !h.suppressErrClosed { - conn.logger.Printf("jsonrpc2 handler: sending response %s: %s\n", resp.ID, err) + conn.logger.Printf("jsonrpc2 handler: sending response %s: %v\n", resp.ID, err) } } } diff --git a/object_test.go b/object_test.go index 3572422..2430e3b 100644 --- a/object_test.go +++ b/object_test.go @@ -23,7 +23,7 @@ func TestAnyMessage(t *testing.T) { var m anyMessage if err := json.Unmarshal([]byte(s), &m); err != nil { if !want.invalid { - t.Errorf("%s: error: %s", s, err) + t.Errorf("%s: error: %v", s, err) } continue }