1
0
Fork 0
mirror of https://github.com/sourcegraph/jsonrpc2.git synced 2026-08-27 15:28:12 +02:00

Always omit params member from request when empty (#67)

With this commit, the JSON encoding of `Request` always omits the params
member when calling `Conn.Call`, `Conn.DispatchCall`, or `Conn.Notify`
with the `params` argument set to `nil`. This change also removes the
`OmitNilParams` call option that was added in commit 8012d496 (#62).

As of this commit, if users desire to send a JSON-RPC request with a
`params` value of `null`, then they may do so by explicitly setting the
`params` argument of `Conn.Call`/`Conn.DispatchCall`/`Conn.Notify` to
`json.RawMessage("null")`.
This commit is contained in:
Sam Herrmann 2023-02-22 03:53:44 -05:00 committed by GitHub
parent 6864d8cc6d
commit ae88a5e7c0
Signed by: GitHub
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 240 additions and 159 deletions

View file

@ -32,7 +32,7 @@ type Error struct {
Data *json.RawMessage `json:"data,omitempty"`
}
// SetError sets e.Data to the JSON representation of v. If JSON
// SetError sets e.Data to the JSON encoding of v. If JSON
// marshaling fails, it panics.
func (e *Error) SetError(v interface{}) {
b, err := json.Marshal(v)