tests/ec/ecdsa_sign.cpp: need to use ecdsa_verify() to check signatures.

different implementations produce different signatures so we can't use hardcoded values.

tests/ec/ecdsa_sign.cpp

@@ -7,8 +7,8 @@ TEST_CASE("ec::ecdsa_sign") {
 	struct testcase {
 		const char *name;
 		libeosio::ec_privkey_t key;
+		libeosio::ec_pubkey_t pub;
 		libeosio::sha256_t dgst;
-		libeosio::ec_signature_t expected;
 	};
 
 	std::vector<testcase> tests = {
@@ -16,6 +16,8 @@ TEST_CASE("ec::ecdsa_sign") {
 			"valid #1",
 			// Private Key: 5Ke4YqL2TCtiUTTA1CVMXSrrEHuK9HzbUSWX791yC2UaX2dWRDw
 			{ 0xf0, 0x2d, 0x00, 0x72, 0x8a, 0x7a, 0x93, 0x86, 0xaf, 0xbe, 0x19, 0xab, 0x79, 0x8c, 0xa1, 0x61, 0xab, 0x96, 0x74, 0x7f, 0xe5, 0x97, 0x19, 0x07, 0xb1, 0xc8, 0x65, 0x63, 0xc8, 0x11, 0xe6, 0x74 },
+			// Public key: EOS6zjfj9Xjk9CYoucZDptdDZ6317eZd622pVvaYtv5q6gwEs9icD
+			{ 0x03, 0x15, 0x93, 0x8a, 0x8e, 0x1d, 0x57, 0x84, 0x9f, 0xab, 0x07, 0x18, 0x67, 0xb5, 0x0c, 0xda, 0xb0, 0x77, 0x62, 0x29, 0xb6, 0x43, 0xb8, 0x67, 0x56, 0xc7, 0xb3, 0xe8, 0x7f, 0xe6, 0x08, 0xf8, 0x4b },
 			{
 				data: {
 					0xab, 0x53, 0x0a, 0x13, 0xe4, 0x59, 0x14, 0x98,
@@ -24,17 +26,13 @@ TEST_CASE("ec::ecdsa_sign") {
 					0x1a, 0xfb, 0xf0, 0x2b, 0x46, 0x0c, 0x6d, 0x1d
 				},
 			},
-			// SIG_K1_KdgBih1poWj8DYZXwLxMdjaHMzYhuAVp7XshR9ZjrZSubZwsgSpiyUKXu44NmCtKgRFswmqKaioWLTuGZrXwYPsSNCSyyr
-			{
-				0x20, 0x44, 0x3f, 0x72, 0x22, 0xfd, 0x7a, 0x1f, 0x56, 0x2d, 0xef, 0x01, 0x55, 0x40, 0xcf, 0x50, 0x6f, 0x5f, 0xdd, 0xfe, 0x71, 0xd7, 0x18, 0xc9, 0xa8, 0xc8, 0xbe, 0x00, 0x96, 0xf8, 0x7c, 0xc7,
-				0x1f, 0x2d, 0xd0, 0xd1, 0xfc, 0x4a, 0x22, 0x6a, 0x25, 0xc4, 0x7c, 0x99, 0xf9, 0xd8, 0x30, 0xfa, 0x8b, 0x5c, 0x33, 0x36, 0x61, 0xd7, 0xcf, 0x6d, 0x04, 0x97, 0x61, 0x76, 0x47, 0x65, 0x30, 0x7b,
-				0x66
-			},
 		},
 		{
 			"valid #2",
 			// Private Key: 5J1VLF3TtdM3FiaUZNjeUXTUmVmRRULSdxrGf3XwQkRAZLcN64b
 			{ 0x19, 0x6f, 0xd7, 0xa5, 0x3f, 0xab, 0x59, 0x8e, 0xa5, 0xef, 0xec, 0x79, 0xdd, 0xbc, 0x49, 0xae, 0xef, 0xff, 0x41, 0x3c, 0x5f, 0xfe, 0x50, 0x3a, 0x66, 0xbc, 0xff, 0xf1, 0x32, 0x1b, 0x8c, 0x2f },
+			// Public key: EOS6tVtKhTpM6yU7kkiRz1AecDJPcBQo2w4x4oytJbJi5PMV2Rcw2
+			{ 0x03, 0x07, 0x69, 0xbb, 0xa5, 0x2c, 0xd2, 0xe1, 0x3b, 0x3e, 0x0a, 0x40, 0xb3, 0xa2, 0x44, 0xad, 0x71, 0x6e, 0x32, 0x64, 0x9c, 0x3a, 0x64, 0x27, 0x4f, 0x31, 0x86, 0x8a, 0x4c, 0x69, 0x58, 0x86, 0x49 },
 			{
 				data: {
 					0x19, 0xd3, 0xe0, 0x8b, 0xbb, 0xad, 0x5f, 0x02,
@@ -43,17 +41,13 @@ TEST_CASE("ec::ecdsa_sign") {
 					0xb4, 0x35, 0xd4, 0x78, 0x6b, 0x93, 0x64, 0xa6
 				},
 			},
-			// SIG_K1_K4XXx6oSYBzcwzscMstvSxruxdkTCinyN9dnRo4DuBkCCpQbCJQcJmbE7aAmNueBYCccHyyDK5JDfMpvewRF2rGUFtSE2y
-			{
-				0x1f, 0x46, 0xde, 0x7a, 0x7e, 0x87, 0xa7, 0xb0, 0x42, 0xce, 0xdc, 0x57, 0xc9, 0x0d, 0x64, 0x4c, 0xc7, 0x4d, 0xe6, 0x19, 0x5d, 0x34, 0x4e, 0xba, 0xfb, 0xdf, 0x26, 0x79, 0xa1, 0xc6, 0x99, 0x98,
-				0xa7, 0x1f, 0x65, 0xcd, 0xab, 0x2d, 0x19, 0x75, 0x27, 0xdc, 0xb2, 0xc5, 0x46, 0x87, 0x5d, 0xbe, 0xc5, 0x8d, 0xb2, 0xb8, 0x7f, 0x15, 0x47, 0xd7, 0xc7, 0x94, 0x0a, 0xd5, 0x52, 0xd9, 0xe3, 0x93,
-				0xd7
-			},
 		},
 		{
 			"valid #3",
 			// Private Key: 5Hz2iVzC9jDcBUGo2EUSPdcvL1s8jxJ6pY95gQX59mHoHx6zi6W
 			{ 0x16, 0x1f, 0xd0, 0x41, 0x21, 0x50, 0x04, 0x13, 0x90, 0x61, 0xb3, 0xbd, 0xc8, 0x83, 0x09, 0xf0, 0x80, 0x3c, 0x90, 0x45, 0x8e, 0x9a, 0x8c, 0xb2, 0xfb, 0x6a, 0x3c, 0x27, 0x51, 0xcf, 0xd9, 0xca },
+			// Public key: EOS7Xtaa4y44gYapth4MH5bdtCvdtQvVLdsW7a8thVAuvNAkj8X7i
+			{ 0x03, 0x5c, 0x50, 0x81, 0xef, 0xa6, 0x46, 0x00, 0x5a, 0xb9, 0xd8, 0x2b, 0xfe, 0xd8, 0xe1, 0x6d, 0x15, 0x42, 0x9e, 0x9a, 0xcb, 0xc9, 0xd6, 0xb3, 0x2e, 0x5a, 0xe3, 0xed, 0xa5, 0x8d, 0x6a, 0x42, 0x6c },
 			{
 				data: {
 					0x1b, 0x01, 0x0b, 0xe5, 0xce, 0x6a, 0x49, 0xc7,
@@ -62,17 +56,13 @@ TEST_CASE("ec::ecdsa_sign") {
 					0xc8, 0xaf, 0x26, 0x1b, 0x15, 0x7e, 0x11, 0xec
 				},
 			},
-			// SIG_K1_K54CVeQjFREm9Z92jutWESZWb9WQfCRZ2KfMtisfsnxedppeSMxTrZ9fYDLiJTfE79zvLCHb5NysAEcNdh7HiBvtU4Ahhh
-			{
-				0x1f, 0x4a, 0xe9, 0x04, 0x20, 0xfa, 0x7b, 0x9d, 0x56, 0xc6, 0x00, 0x5c, 0x83, 0x70, 0xa9, 0x26, 0x41, 0x7d, 0xe8, 0xeb, 0xe7, 0x75, 0xea, 0x6f, 0x75, 0xa7, 0x7c, 0x98, 0x10, 0x27, 0xbf, 0xce,
-				0x48, 0x41, 0x74, 0xb0, 0xe3, 0xb1, 0x4b, 0x06, 0x2c, 0x53, 0x93, 0xbc, 0x35, 0xea, 0xac, 0xd7, 0x9e, 0x07, 0xa7, 0xa1, 0x2e, 0xac, 0xa0, 0x81, 0x45, 0xdb, 0xd4, 0x53, 0x68, 0xda, 0xaa, 0xc6,
-				0xfc
-			},
 		},
 		{
 			"valid #4",
 			// Private Key: 5KbH8qYyg6f93gHuAdbDmwCVMoarXHqEn5CdbW2VtHTyMsLShwM
 			{ 0xe9, 0xdb, 0x4d, 0xdc, 0x8e, 0x08, 0xd2, 0x04, 0x75, 0xc2, 0xb6, 0xf7, 0x14, 0x9e, 0xa2, 0x16, 0xd7, 0x2b, 0x34, 0x3b, 0xba, 0xb4, 0x7d, 0xe6, 0xd3, 0x96, 0xc1, 0x63, 0x82, 0xdf, 0x2d, 0x13 },
+			// Public key: EOS6E12fqQqWLYJS32ffB6LaQYxyDXUQSPfMTMnj6tc5bgntZKcBy
+			{ 0x02, 0xaf, 0xff, 0xeb, 0xef, 0x47, 0x70, 0x58, 0x2f, 0x9b, 0x66, 0x6c, 0xe0, 0xea, 0x84, 0x32, 0x41, 0xa0, 0x94, 0x36, 0x30, 0x9b, 0xfc, 0xdb, 0x9a, 0x58, 0xdd, 0x0e, 0xe6, 0x3e, 0xd4, 0x5a, 0xcd },
 			{
 				data: {
 					0xbc, 0x83, 0xbe, 0xe1, 0x73, 0x82, 0xfb, 0x02,
@@ -81,17 +71,13 @@ TEST_CASE("ec::ecdsa_sign") {
 					0x04, 0xf2, 0x95, 0xbc, 0xfa, 0xed, 0x8f, 0xaa
 				},
 			},
-			// SIG_K1_K56oByqkwGeRhn8TfiWdspSzmNy99McLeQ7R9UFJzKgQWjAXVV4hAf1ophqs4RGtBzBTaWA1oQyaWUfPr84VcbzMqLc5H5
-			{
-				0x1f, 0x4b, 0x40, 0xac, 0x12, 0x8c, 0xb1, 0x78, 0xe0, 0xe3, 0x09, 0xe5, 0x74, 0x3e, 0xe5, 0xd2, 0xf4, 0x46, 0xaa, 0x14, 0x68, 0x39, 0x97, 0xc4, 0x4f, 0x92, 0x03, 0x3a, 0x72, 0x4d, 0x68, 0xe5,
-				0x03, 0x71, 0xa7, 0xd9, 0x41, 0x61, 0xec, 0x5a, 0xe4, 0xb5, 0x3a, 0xa9, 0xc7, 0xd4, 0x93, 0x44, 0x6e, 0xb1, 0xe1, 0x66, 0x13, 0xc9, 0x2d, 0x74, 0x82, 0xc9, 0x42, 0x55, 0xef, 0x21, 0x1d, 0x22,
-				0xe3
-			},
 		},
 		{
 			"valid #5",
 			// Private Key: 5KUb7Y5UqoVggesYJzuNcEmjGtQMpfMiVaEDr9E5K1vNgZqvHok
 			{ 0xda, 0xaa, 0x85, 0x66, 0xf5, 0xc9, 0x4c, 0xfa, 0x1f, 0x72, 0x30, 0x8e, 0xb8, 0xed, 0x8c, 0xd7, 0x2b, 0x08, 0x80, 0xc8, 0x2b, 0x9d, 0xe9, 0x0a, 0x81, 0xec, 0x8f, 0x3e, 0xe7, 0x75, 0xf0, 0x3c },
+			// Public key: EOS6uqJC6F7eEMq7SHREhTzRoAT7uumrmHDDYC595CJKeBgPvPojd
+			{ 0x03, 0x0a, 0x71, 0x8e, 0x48, 0x1a, 0x7a, 0x55, 0x84, 0xb9, 0xaf, 0x24, 0xca, 0x8f, 0x85, 0xcd, 0x0f, 0x55, 0x5c, 0xcf, 0xb3, 0x7b, 0x39, 0x5b, 0xa5, 0xfc, 0xb9, 0xaf, 0x26, 0xc7, 0xc7, 0x88, 0x7b },
 			{
 				data: {
 					0xfc, 0xb2, 0x0d, 0xa1, 0x22, 0x6c, 0xcc, 0x59,
@@ -100,17 +86,13 @@ TEST_CASE("ec::ecdsa_sign") {
 					0x72, 0x3e, 0x94, 0xcc, 0x05, 0xe1, 0x51, 0xc7
 				},
 			},
-			// SIG_K1_KcU7REFtK9uNhrstdi2WrvF4mBsAKQjvUsSbL4zDWywz3FTNbNMQq1g8bKNEkmD22AH2dDEAPBkLqDYERk38gJygG3wJCx
-			{
-				0x20, 0x3b, 0x03, 0x56, 0x1d, 0x99, 0xca, 0xcd, 0xb4, 0xfe, 0x8a, 0x55, 0x0a, 0x88, 0xe1, 0x84, 0x2b, 0x73, 0xd4, 0x7e, 0x8a, 0x5b, 0x07, 0xe4, 0xe4, 0x38, 0x70, 0x7f, 0x5d, 0xcc, 0x6a, 0xe2,
-				0x5b, 0x1a, 0x37, 0xa2, 0x5b, 0x04, 0xaa, 0x55, 0xa6, 0x43, 0x75, 0x1b, 0x86, 0x20, 0x8a, 0xd3, 0xf8, 0xb0, 0xcd, 0x92, 0x30, 0x2b, 0x3b, 0xf9, 0xdc, 0x52, 0x39, 0xf8, 0xdd, 0xe7, 0xfe, 0xff,
-				0x35
-			},
 		},
 		{
 			"valid #6",
 			// Private Key: 5K4ErsLWnMv53tfFhtp5JF9CYKwmr89Pt2BEpoak1bfdgvHK2fj
 			{ 0xa3, 0x60, 0xd7, 0x80, 0xdc, 0xe8, 0x3c, 0x5d, 0xc8, 0x61, 0xa1, 0x24, 0x6f, 0x65, 0x9e, 0x16, 0x79, 0x40, 0x10, 0x27, 0xfc, 0x9a, 0x40, 0x3f, 0x2b, 0x40, 0x7a, 0xfd, 0x1e, 0x42, 0xde, 0x84 },
+			// Public key: EOS5YiBwqnFXqeb5hCmwV9bLHp6Jg5hVnRjzYVApf2DXyRGr7B7kZ
+			{ 0x02, 0x56, 0xc9, 0x41, 0x90, 0x44, 0x8a, 0xcc, 0x89, 0x91, 0x79, 0xaf, 0x4e, 0x3a, 0x72, 0xa7, 0x24, 0x86, 0x7f, 0xd8, 0x03, 0x07, 0x04, 0x30, 0xd3, 0xf3, 0x6b, 0x20, 0x94, 0x85, 0x78, 0xfc, 0x38 },
 			{
 				data: {
 					0xd2, 0xfa, 0xa6, 0x97, 0x12, 0xd7, 0x04, 0x05,
@@ -119,12 +101,6 @@ TEST_CASE("ec::ecdsa_sign") {
 					0x04, 0xfa, 0x7d, 0x70, 0xe7, 0xdc, 0x86, 0xb2
 				},
 			},
-			// SIG_K1_KmHSJGQmFPVWqs48hF2YTWm51wS6CU4jobLPjKTyrCeGvwmt1YHLGgkPnENEgujvpJLYRGbffwtfqzPdDtSUXeBDAATKAH
-			{
-				0x20, 0x69, 0x9f, 0x82, 0x48, 0xd6, 0x57, 0x42, 0x1f, 0xd6, 0x76, 0x15, 0x4c, 0xb1, 0x9c, 0xd7, 0x04, 0x1d, 0xb7, 0xed, 0x1b, 0xff, 0x26, 0xbd, 0x2e, 0xc3, 0x65, 0xbf, 0xcb, 0xfb, 0x9b, 0xae,
-				0xe5, 0x77, 0x69, 0x23, 0xa8, 0xda, 0x84, 0x1c, 0x2f, 0x03, 0x95, 0x48, 0x33, 0x95, 0x85, 0xdf, 0x43, 0x69, 0xd4, 0x17, 0x37, 0x24, 0x86, 0xdf, 0x81, 0x08, 0xab, 0x81, 0xc4, 0x2c, 0xde, 0x61,
-				0x4a
-			},
 		},
 	};
 
@@ -135,7 +111,15 @@ TEST_CASE("ec::ecdsa_sign") {
 			libeosio::ec_signature_t result;
 
 			CHECK( libeosio::ecdsa_sign(it->key, &it->dgst, result) == 0 );
-			CHECK( result == it->expected );
+
+			// Need to use verify here as different implemententations produces different signatures.
+			// (i have tested eosjs, eos-go and ofc libeosio)
+			// However, the signatures are correct and can be validated by all implementations.
+			//
+			// Now, how do we know that ecdsa_verify is correct?
+			// well, in escdsa_verify.cpp there are tests that checks hardcoded signatures generated by different implementations and should be fine.
+
+			CHECK( libeosio::ecdsa_verify(&it->dgst, result, it->pub) == 0);
 		}
 	}
 	libeosio::ec_shutdown();