From bfa772c48644081db244fa640f7390064cc0be22 Mon Sep 17 00:00:00 2001
From: Henrik Hautakoski <henrik.hautakoski@gmail.com>
Date: Wed, 8 Aug 2018 23:16:57 +0200
Subject: [PATCH] app/views/user/settings.volt: cleaning up social links with
 array and loop.

---
 app/views/user/settings.volt | 37 ++++++++++++++----------------------
 1 file changed, 14 insertions(+), 23 deletions(-)

diff --git a/app/views/user/settings.volt b/app/views/user/settings.volt
index 6ff4dc6..3f3af81 100644
--- a/app/views/user/settings.volt
+++ b/app/views/user/settings.volt
@@ -1,3 +1,10 @@
+{%
+    set social_links = [
+        'github' : [ 'connected': user.getGithubId() > 0 ],
+        'gitlab' : [ 'connected': user.getGitlabId() > 0, 'class': 'text-gitlab' ],
+        'google' : [ 'connected': user.getGoogleId() > 0, 'class': 'text-google' ]
+    ]
+%}
 
 <div class="section">
 
@@ -44,33 +51,17 @@
 
                 <hr />
 
+                {% for name,info in social_links %}
                 <div class="col-sm-2 text-center">
-                    <div>{{ icon('brand/github', [ '3x' ]) }}</div>
-                    {% if user.getGithubId() > 0 %}
-                    <a href="{{ url(['for': 'oauth-disconnect', 'provider': 'github']) }}">Disconnect</a>
+                    {%  set class = info['class'] | default(false) %}
+                    <div{{ class ? ' class="%s"'|format(class) : '' }}>{{ icon('brand/' ~ name, [ '3x' ]) }}</div>
+                    {% if info['connected'] %}
+                        <a href="{{ url(['for': 'oauth-disconnect', 'provider': name]) }}">Disconnect</a>
                     {% else %}
-                    <a href="{{ url(['for': 'oauth', 'strategy': 'github']) }}">Connect</a>
+                        <a href="{{ url(['for': 'oauth', 'strategy': name]) }}">Connect</a>
                     {% endif %}
                 </div>
-
-                <div class="col-sm-2 text-center">
-                    <div class="text-gitlab">{{ icon('brand/gitlab', [ '3x' ]) }}</div>
-                    {% if user.getGitlabId() > 0 %}
-                    <a href="{{ url(['for': 'oauth-disconnect', 'provider': 'gitlab' ]) }}">Disconnect</a>
-                    {% else %}
-                    <a href="{{ url(['for': 'oauth', 'strategy': 'gitlab']) }}">Connect</a>
-                    {% endif %}
-                </div>
-
-                <div class="col-sm-2 text-center">
-                    <div class="text-google">{{ icon('brand/google', [ '3x' ]) }}</div>
-                    {% if user.getGoogleId() > 0 %}
-                    <a href="{{ url(['for': 'oauth-disconnect', 'provider': 'google']) }}">Disconnect</a>
-                    {% else %}
-                    <a href="{{url(['for': 'oauth', 'strategy': 'google']) }}">Connect</a>
-                    {% endif %}
-
-                </div>
+                {% endfor %}
 
             </div>
         </div>