From 20654bb3f0d2c91fe4a11f5eac4e94ac382ff0ba Mon Sep 17 00:00:00 2001 From: Henrik Hautakoski Date: Sun, 31 Jul 2022 23:10:47 +0200 Subject: [PATCH 01/51] npm: update bootstrap to 5.2.0 --- package-lock.json | 53 +++++++++++++++++++++++++++++++++++++---------- package.json | 3 ++- 2 files changed, 44 insertions(+), 12 deletions(-) diff --git a/package-lock.json b/package-lock.json index c417ba6..4bfc61a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -8,7 +8,8 @@ "version": "1.0.2", "license": "ISC", "devDependencies": { - "bootstrap-sass": "^3.3.7", + "@popperjs/core": "^2.11.5", + "bootstrap": "^5.2.0", "gulp": "^4.0.0", "gulp-concat": "^2.6.1", "gulp-csso": "^4.0.1", @@ -20,6 +21,16 @@ "sass": "^1.54.0" } }, + "node_modules/@popperjs/core": { + "version": "2.11.5", + "resolved": "https://registry.npmjs.org/@popperjs/core/-/core-2.11.5.tgz", + "integrity": "sha512-9X2obfABZuDVLCgPK9aX0a/x4jaOEweTTWE2+9sr0Qqqevj2Uv5XorvusThmc9XGYpS9yI+fhh8RTafBtGposw==", + "dev": true, + "funding": { + "type": "opencollective", + "url": "https://opencollective.com/popperjs" + } + }, "node_modules/ansi-colors": { "version": "1.1.0", "resolved": "https://registry.npmjs.org/ansi-colors/-/ansi-colors-1.1.0.tgz", @@ -366,11 +377,24 @@ "file-uri-to-path": "1.0.0" } }, - "node_modules/bootstrap-sass": { - "version": "3.3.7", - "resolved": "https://registry.npmjs.org/bootstrap-sass/-/bootstrap-sass-3.3.7.tgz", - "integrity": "sha1-ZZbHq0D2Y3OTMjqwvIDQZPxjBJg=", - "dev": true + "node_modules/bootstrap": { + "version": "5.2.0", + "resolved": "https://registry.npmjs.org/bootstrap/-/bootstrap-5.2.0.tgz", + "integrity": "sha512-qlnS9GL6YZE6Wnef46GxGv1UpGGzAwO0aPL1yOjzDIJpeApeMvqV24iL+pjr2kU4dduoBA9fINKWKgMToobx9A==", + "dev": true, + "funding": [ + { + "type": "github", + "url": "https://github.com/sponsors/twbs" + }, + { + "type": "opencollective", + "url": "https://opencollective.com/bootstrap" + } + ], + "peerDependencies": { + "@popperjs/core": "^2.11.5" + } }, "node_modules/brace-expansion": { "version": "1.1.11", @@ -4378,6 +4402,12 @@ } }, "dependencies": { + "@popperjs/core": { + "version": "2.11.5", + "resolved": "https://registry.npmjs.org/@popperjs/core/-/core-2.11.5.tgz", + "integrity": "sha512-9X2obfABZuDVLCgPK9aX0a/x4jaOEweTTWE2+9sr0Qqqevj2Uv5XorvusThmc9XGYpS9yI+fhh8RTafBtGposw==", + "dev": true + }, "ansi-colors": { "version": "1.1.0", "resolved": "https://registry.npmjs.org/ansi-colors/-/ansi-colors-1.1.0.tgz", @@ -4648,11 +4678,12 @@ "file-uri-to-path": "1.0.0" } }, - "bootstrap-sass": { - "version": "3.3.7", - "resolved": "https://registry.npmjs.org/bootstrap-sass/-/bootstrap-sass-3.3.7.tgz", - "integrity": "sha1-ZZbHq0D2Y3OTMjqwvIDQZPxjBJg=", - "dev": true + "bootstrap": { + "version": "5.2.0", + "resolved": "https://registry.npmjs.org/bootstrap/-/bootstrap-5.2.0.tgz", + "integrity": "sha512-qlnS9GL6YZE6Wnef46GxGv1UpGGzAwO0aPL1yOjzDIJpeApeMvqV24iL+pjr2kU4dduoBA9fINKWKgMToobx9A==", + "dev": true, + "requires": {} }, "brace-expansion": { "version": "1.1.11", diff --git a/package.json b/package.json index 85f12f0..cff9a0f 100644 --- a/package.json +++ b/package.json @@ -3,7 +3,8 @@ "version": "1.0.2", "description": "HTTP Callback Tool", "devDependencies": { - "bootstrap-sass": "^3.3.7", + "@popperjs/core": "^2.11.5", + "bootstrap": "^5.2.0", "gulp": "^4.0.0", "gulp-concat": "^2.6.1", "gulp-csso": "^4.0.1", From 351562f36b42ec65d188cc5c2c0fe1b82a0199d2 Mon Sep 17 00:00:00 2001 From: Henrik Hautakoski Date: Sun, 31 Jul 2022 23:18:38 +0200 Subject: [PATCH 02/51] gulpfile.js: update to build with bootstrap 5.2.0 --- gulpfile.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gulpfile.js b/gulpfile.js index fd3b36d..54dd86d 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -14,7 +14,7 @@ var config = { pattern: 'app/assets/sass/**/*.scss', src: 'app/assets/sass/application.scss', opt: { - includePaths: [ 'node_modules/bootstrap-sass/assets/stylesheets' ] + includePaths: [ 'node_modules' ] }, outputDir: 'public/css', outputName: 'application' @@ -22,8 +22,9 @@ var config = { js: { src: [ 'node_modules/jquery/dist/jquery.js', + 'node_modules/@popperjs/core/dist/umd/popper.js', // Bootstrap - 'node_modules/bootstrap-sass/assets/javascripts/bootstrap.js', + 'node_modules/bootstrap/dist/js/bootstrap.js', // Font Awesome 'app/assets/js/font-awesome/regular.js', 'app/assets/js/font-awesome/solid.js', From 676f358e3abbb8b9b258560ce2b33605b9221d13 Mon Sep 17 00:00:00 2001 From: Henrik Hautakoski Date: Sun, 31 Jul 2022 23:19:19 +0200 Subject: [PATCH 03/51] Adding app/assets/sass/mixins/_center-block.scss --- app/assets/sass/_mixins.scss | 1 + app/assets/sass/mixins/_center-block.scss | 6 ++++++ 2 files changed, 7 insertions(+) create mode 100644 app/assets/sass/mixins/_center-block.scss diff --git a/app/assets/sass/_mixins.scss b/app/assets/sass/_mixins.scss index 1d56b71..ff9cabb 100644 --- a/app/assets/sass/_mixins.scss +++ b/app/assets/sass/_mixins.scss @@ -1,3 +1,4 @@ @import "mixins/button"; +@import "mixins/center-block"; @import "mixins/icon-vcenter"; diff --git a/app/assets/sass/mixins/_center-block.scss b/app/assets/sass/mixins/_center-block.scss new file mode 100644 index 0000000..0a0dcb1 --- /dev/null +++ b/app/assets/sass/mixins/_center-block.scss @@ -0,0 +1,6 @@ + +@mixin center-block() { + display: block; + margin-left: auto; + margin-right: auto; +} From 1182f9439b133d5cf3f1411321e8b49813d2a1c5 Mon Sep 17 00:00:00 2001 From: Henrik Hautakoski Date: Sun, 31 Jul 2022 23:20:01 +0200 Subject: [PATCH 04/51] Adding app/assets/sass/base/_utils.scss --- app/assets/sass/base/_utils.scss | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 app/assets/sass/base/_utils.scss diff --git a/app/assets/sass/base/_utils.scss b/app/assets/sass/base/_utils.scss new file mode 100644 index 0000000..3e61501 --- /dev/null +++ b/app/assets/sass/base/_utils.scss @@ -0,0 +1,4 @@ + +.center-block { + @include center-block(); +} From 22f49280deefcd368a4ee2c4d5a903868e08fbc0 Mon Sep 17 00:00:00 2001 From: Henrik Hautakoski Date: Sun, 31 Jul 2022 23:38:26 +0200 Subject: [PATCH 05/51] app/assets/sass/views/_about.scss: update to bootstrap 5.2.0 mixins. --- app/assets/sass/views/_about.scss | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/app/assets/sass/views/_about.scss b/app/assets/sass/views/_about.scss index 62579ca..9c41d5f 100644 --- a/app/assets/sass/views/_about.scss +++ b/app/assets/sass/views/_about.scss @@ -3,11 +3,16 @@ @extend .row; &-main { - @include make-sm-column(8); + @include make-col-ready(); + @include media-breakpoint-up(sm) { + @include make-col(8); + } } &-reference { - @include make-sm-column(4); + @include make-col-ready(); + @include media-breakpoint-up(sm) { + @include make-col(4); + } } } - From 10c5935620051cefefad34ef6980508cc585a9ec Mon Sep 17 00:00:00 2001 From: Henrik Hautakoski Date: Sun, 31 Jul 2022 23:39:03 +0200 Subject: [PATCH 06/51] app/assets/sass/components/_callback-list.scss: use clearfix mixin instead of extend. --- app/assets/sass/components/_callback-list.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/sass/components/_callback-list.scss b/app/assets/sass/components/_callback-list.scss index c2a4b5b..f010b65 100644 --- a/app/assets/sass/components/_callback-list.scss +++ b/app/assets/sass/components/_callback-list.scss @@ -1,7 +1,7 @@ .callback-list-item { - @extend .clearfix; + @include clearfix(); position: relative; padding: .6em 1em; From 44b7a3a7b040c48689633a4825cd0af31233fc58 Mon Sep 17 00:00:00 2001 From: Henrik Hautakoski Date: Sun, 31 Jul 2022 23:39:38 +0200 Subject: [PATCH 07/51] app/assets/sass/components/_badge.scss: brand-color is named primary in bootstrap 5.2.0 --- app/assets/sass/components/_badge.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/sass/components/_badge.scss b/app/assets/sass/components/_badge.scss index 46107e7..254e560 100644 --- a/app/assets/sass/components/_badge.scss +++ b/app/assets/sass/components/_badge.scss @@ -13,6 +13,6 @@ &-primary { color: white; - background-color: $brand-color; + background-color: $primary; } } From a971a5553ab11d16ed070d1f0ea5cd6ce8c5b6ba Mon Sep 17 00:00:00 2001 From: Henrik Hautakoski Date: Sun, 31 Jul 2022 23:40:02 +0200 Subject: [PATCH 08/51] app/assets/sass/layout/_sections.scss: brand-color is named primary in bootstrap 5.2.0 --- app/assets/sass/layout/_sections.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/sass/layout/_sections.scss b/app/assets/sass/layout/_sections.scss index b53a4cf..cfbb55a 100644 --- a/app/assets/sass/layout/_sections.scss +++ b/app/assets/sass/layout/_sections.scss @@ -6,7 +6,7 @@ .head-section { - background-color: $brand-color; + background-color: $primary; background-image: url(#{$image-path}/header-pattern.jpg); margin-bottom: 60px; From 98ed31b7f8e2349e1cef928fdac25de6edcb17b7 Mon Sep 17 00:00:00 2001 From: Henrik Hautakoski Date: Sun, 31 Jul 2022 23:41:07 +0200 Subject: [PATCH 09/51] app/assets/sass/components/_pagination.scss: extend center-block instead of nav (only need centering anyway) --- app/assets/sass/components/_pagination.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/sass/components/_pagination.scss b/app/assets/sass/components/_pagination.scss index 13c63bc..78fa41b 100644 --- a/app/assets/sass/components/_pagination.scss +++ b/app/assets/sass/components/_pagination.scss @@ -1,6 +1,6 @@ .pagination { - @extend .nav; + @extend .center-block; margin-top: 1em; margin-bottom: 1em; From 260fc641025a09fa72bcab4aec6c687fb0af222a Mon Sep 17 00:00:00 2001 From: Henrik Hautakoski Date: Sun, 31 Jul 2022 23:43:32 +0200 Subject: [PATCH 10/51] app/assets/sass/layout/_navigation.scss: use bootstrap 5.2.0 mixin for media queries. also skip $navbar-breakpoint-min variable and just use "md" breakpoint. --- app/assets/sass/layout/_navigation.scss | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/app/assets/sass/layout/_navigation.scss b/app/assets/sass/layout/_navigation.scss index 213f8d3..84c9caf 100644 --- a/app/assets/sass/layout/_navigation.scss +++ b/app/assets/sass/layout/_navigation.scss @@ -34,9 +34,9 @@ font-size: 24px; // Hide for larger view-ports. - @media (min-width: $navbar-breakpoint-min) { - display: none !important; - } + @include media-breakpoint-up(md) { + @include visually-hidden; + } } // Menu @@ -47,8 +47,7 @@ > li { // Inline list for larger viewports. - @media (min-width: $navbar-breakpoint-min) { - + @include media-breakpoint-up(md) { display: inline-block; a { @@ -76,7 +75,7 @@ } // Only for small viewports. - @media (max-width: $navbar-breakpoint-min) { + @include media-breakpoint-down(md) { margin: 1em 0; @@ -99,7 +98,8 @@ } // Always show menu for larger viewport. - @media (min-width: $navbar-breakpoint-min) { + + @include media-breakpoint-up(md) { &-menu.collapse { display: block; } From a214fe3fcfe7ba55764f9ee46579b7bdb0fd88d1 Mon Sep 17 00:00:00 2001 From: Henrik Hautakoski Date: Sun, 31 Jul 2022 23:50:01 +0200 Subject: [PATCH 11/51] app/assets/sass/base/_typography.scss: fix underlines on links. bootstrap 3.4.0 only had underlines for hover links while 5.2.0 has them on for all states. So enable them for a:hover again here. while we disable them in bootstrap. --- app/assets/sass/base/_typography.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/assets/sass/base/_typography.scss b/app/assets/sass/base/_typography.scss index 93ac4c4..31e88b9 100644 --- a/app/assets/sass/base/_typography.scss +++ b/app/assets/sass/base/_typography.scss @@ -12,3 +12,7 @@ .text-gitlab { color: $gitlab-color; } .text-google { color: $google-color; } .text-linkedin { color: $linkedin-color; } + +a:hover { + text-decoration: underline; +} From 4403f5c2bb0cbc59f9b96251f738e6769dc08666 Mon Sep 17 00:00:00 2001 From: Henrik Hautakoski Date: Sun, 31 Jul 2022 23:50:36 +0200 Subject: [PATCH 12/51] app/assets/sass/layout/_navigation.scss: use cleafix mixin instead of extend. --- app/assets/sass/layout/_navigation.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/sass/layout/_navigation.scss b/app/assets/sass/layout/_navigation.scss index 84c9caf..3d32d71 100644 --- a/app/assets/sass/layout/_navigation.scss +++ b/app/assets/sass/layout/_navigation.scss @@ -6,7 +6,7 @@ .navigation { // General styling (for all viewport widths) - @extend .clearfix; + @include clearfix(); @extend .container; min-height: $navbar-height; From 18466d273c22085cb97f4b538626e338632b5be7 Mon Sep 17 00:00:00 2001 From: Henrik Hautakoski Date: Sun, 31 Jul 2022 23:51:18 +0200 Subject: [PATCH 13/51] app/assets/sass/layout/_navigation.scss: "pull-right" is renamed to "float-end" in bootstrap 5.2.0 --- app/assets/sass/layout/_navigation.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/sass/layout/_navigation.scss b/app/assets/sass/layout/_navigation.scss index 3d32d71..4e0fb11 100644 --- a/app/assets/sass/layout/_navigation.scss +++ b/app/assets/sass/layout/_navigation.scss @@ -108,7 +108,7 @@ // User Menu // ------------------- &-user-menu { - @extend .nav, .pull-right; + @extend .nav, .float-end; margin-top: 10px; &-login { From 8fad84bd4b829a664d55e7fef9958f38554fb269 Mon Sep 17 00:00:00 2001 From: Henrik Hautakoski Date: Sun, 31 Jul 2022 23:53:32 +0200 Subject: [PATCH 14/51] app/assets/sass/layout/_navigation.scss: "border-radius-base" is renamed to "border-radius" in bootstrap 5.2.0 --- app/assets/sass/layout/_navigation.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/sass/layout/_navigation.scss b/app/assets/sass/layout/_navigation.scss index 4e0fb11..ff641c5 100644 --- a/app/assets/sass/layout/_navigation.scss +++ b/app/assets/sass/layout/_navigation.scss @@ -123,7 +123,7 @@ display: inline-block; padding: .3em .8em; background: $usermenu-button-bg; - border-radius: $border-radius-base; + border-radius: $border-radius; &:hover { background: $usermenu-button-hover-bg; From 33e2cec8a7cb092d853c295f1d49063932af93ce Mon Sep 17 00:00:00 2001 From: Henrik Hautakoski Date: Mon, 1 Aug 2022 21:39:48 +0200 Subject: [PATCH 15/51] app/assets/sass/layout/_navigation.scss: hack margins for menu items abit. --- app/assets/sass/layout/_navigation.scss | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/app/assets/sass/layout/_navigation.scss b/app/assets/sass/layout/_navigation.scss index ff641c5..e23e112 100644 --- a/app/assets/sass/layout/_navigation.scss +++ b/app/assets/sass/layout/_navigation.scss @@ -52,12 +52,8 @@ a { display: block; - @include navbar-vertical-align($line-height-computed + ($navbar-link-vertical-spacing * 2)); + margin: 4px calc($navbar-link-spacing / 2); padding: $navbar-link-vertical-spacing 10px $navbar-link-vertical-spacing; - line-height: $line-height-computed; - - margin-left: calc($navbar-link-spacing / 2); - margin-right: calc($navbar-link-spacing / 2); &:hover { color: $navbar-link-hover-color; From 96a80cf6e9aec251991466282b13a278ff19c25c Mon Sep 17 00:00:00 2001 From: Henrik Hautakoski Date: Mon, 1 Aug 2022 21:40:36 +0200 Subject: [PATCH 16/51] app/assets/sass/layout/_navigation.scss: .dropdown-menu-right does not exist. so don't extend it. --- app/assets/sass/layout/_navigation.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/app/assets/sass/layout/_navigation.scss b/app/assets/sass/layout/_navigation.scss index e23e112..97b15de 100644 --- a/app/assets/sass/layout/_navigation.scss +++ b/app/assets/sass/layout/_navigation.scss @@ -128,7 +128,6 @@ &-list { @extend .dropdown-menu; - @extend .dropdown-menu-right; vertical-align: middle; > li > a { From 897da2ad27dc34c5530f07917fdd418464a1aa8f Mon Sep 17 00:00:00 2001 From: Henrik Hautakoski Date: Mon, 1 Aug 2022 21:41:29 +0200 Subject: [PATCH 17/51] app/views/_common/_components/navigation.volt: update dropdown to bootstrap 5.2.0 --- app/views/_common/_components/navigation.volt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/views/_common/_components/navigation.volt b/app/views/_common/_components/navigation.volt index 7f05d1c..62c2317 100644 --- a/app/views/_common/_components/navigation.volt +++ b/app/views/_common/_components/navigation.volt @@ -9,12 +9,12 @@ {% if auth.hasIdentity() %}