archive/heritage-wow
1
0
Fork 0
Code Releases Activity

app/Jobs/ImportProfession.php: fix a bug resulting in duplicate records instead of update existing.

Browse source 
We search for recipes by spell, but if a record existed before spell relationship was added. it's null and we wont find it, so we create a duplicated one.

This patch will also search for craft->name and update existing records.
This commit is contained in:
Henrik Hautakoski 2021-07-09 18:16:27 +02:00
parent 3085de6334
commit f105890494
2 changed files with 55 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

40
tests/Feature/ProfessionImportTest.php
View file

@ -10,6 +10,8 @@ use App\Models\User;
use App\Models\Character;
use App\Models\CharacterProfession;
use App\Models\Profession;
use App\Models\Item;
use App\Models\Recipe;
use App\Jobs\ImportProfession;
class ProfessionImportTest extends TestCase
@ -210,4 +212,42 @@ class ProfessionImportTest extends TestCase
$this->assertEquals('Nexus Crystal', $recipes[1]->reagents[0]->name);
$this->assertEquals(1, $recipes[1]->reagents[0]->quantity);
}
public function test_import_does_not_create_duplicate_recipes_if_spell_relationship_is_missing()
{
$character = Character::factory()->create([ 'name' => 'Duplicated']);
$profession = Profession::factory()->create([ 'name' => 'My Unique Profession' ]);
$item = Item::factory()->create(['name' => 'Unique Recipe']);
$recipe = Recipe::factory()
->for($profession)
->for($item, 'craft')
->create(['spell_id' => null]);
$data = (object) [
"player" => $character->name,
"profession" => (object) [
"name" => $profession->name,
"level" => 375,
"maxLevel" => 375,
"recipes" => [
(object) [
"name" => $item->name,
"num" => 0,
"categorie" => "none",
"items" => [],
"spellId" => 1337
]
]
]
];
ImportProfession::dispatch($character, $data);
$this->assertEquals(1, Recipe::count());
$this->assertDatabaseHas('recipes', [
'spell_id' => 1337,
'item_id' => $item->id,
]);
}
}