rbtree.c: moved tree assertion from the test.
This commit is contained in:
parent
50c53e79bf
commit
41a253a00a
2 changed files with 75 additions and 64 deletions
|
|
@ -1,10 +1,4 @@
|
|||
|
||||
/*
|
||||
* rb_assert should be called after every rbtree_* operation (not just only the one's
|
||||
* that actualy performs changes to the tree) to ensure the tree is valid after the
|
||||
* function is done.
|
||||
*/
|
||||
|
||||
#include <string.h>
|
||||
#include <stdio.h>
|
||||
#include <stdlib.h>
|
||||
|
|
@ -14,8 +8,6 @@
|
|||
#define NODES 3000
|
||||
#define MAX_VAL (3*(NODES/4))
|
||||
|
||||
#define is_red(n) ((n) != NULL && (n)->color == RB_RED)
|
||||
|
||||
static int vcmp(const void *a, const void *b);
|
||||
static void vdelete(void *ptr);
|
||||
|
||||
|
|
@ -23,48 +15,6 @@ static void vdelete(void *ptr);
|
|||
static rbtree tree = RBTREE_INIT(vdelete, NULL, vcmp);
|
||||
static int keyref[NODES];
|
||||
|
||||
static int rb_assert(rbnode *node) {
|
||||
|
||||
int rh, lh;
|
||||
rbnode *ln, *rn;
|
||||
|
||||
if (node == NULL) {
|
||||
return 1;
|
||||
}
|
||||
|
||||
ln = node->child[0];
|
||||
rn = node->child[1];
|
||||
|
||||
if (is_red(node)) {
|
||||
/* double red violation */
|
||||
if (is_red(ln) || is_red(rn)) {
|
||||
die("Double red");
|
||||
return 0;
|
||||
}
|
||||
}
|
||||
|
||||
lh = rb_assert(ln);
|
||||
rh = rb_assert(rn);
|
||||
|
||||
if ( (ln != NULL && vcmp(ln->key, node->key) >= 0) &&
|
||||
(rn != NULL && vcmp(rn->key, node->key) <= 0) ) {
|
||||
die("BST violation");
|
||||
return 0;
|
||||
}
|
||||
|
||||
if (rh != 0 && lh != 0) {
|
||||
|
||||
if (rh != lh) {
|
||||
die("Black height violation");
|
||||
return 0;
|
||||
}
|
||||
|
||||
return (is_red(node)) ? lh : lh+1;
|
||||
}
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int vcmp(const void *a, const void *b) {
|
||||
|
||||
return *((int*)a) - *((int*)b);
|
||||
|
|
@ -119,10 +69,8 @@ static void setup(int sorted) {
|
|||
if (sorted)
|
||||
qsort(keyref, NODES, sizeof(keyref[0]), vcmp);
|
||||
|
||||
for(i=0; i < NODES; i++) {
|
||||
for(i=0; i < NODES; i++)
|
||||
rbtree_insert(&tree, &keyref[i]);
|
||||
rb_assert(tree.root);
|
||||
}
|
||||
}
|
||||
|
||||
static void teardown() {
|
||||
|
|
@ -130,7 +78,6 @@ static void teardown() {
|
|||
int i;
|
||||
|
||||
rbtree_free(&tree);
|
||||
rb_assert(tree.root);
|
||||
|
||||
for(i=0; i < NODES; i++)
|
||||
keyref[i] = -1;
|
||||
|
|
@ -141,13 +88,10 @@ void test_rbtree_is_empty() {
|
|||
setup(0);
|
||||
|
||||
assert(rbtree_is_empty(&tree) == 0);
|
||||
rb_assert(tree.root);
|
||||
|
||||
rbtree_free(&tree);
|
||||
rb_assert(tree.root);
|
||||
|
||||
assert(rbtree_is_empty(&tree));
|
||||
rb_assert(tree.root);
|
||||
|
||||
teardown();
|
||||
}
|
||||
|
|
@ -164,13 +108,11 @@ void test_rbtree_delete() {
|
|||
continue;
|
||||
|
||||
assert(rbtree_delete(&tree, &keyref[i]));
|
||||
rb_assert(tree.root);
|
||||
}
|
||||
|
||||
/* delete a key that does not exist */
|
||||
i = MAX_VAL + 512;
|
||||
assert(rbtree_delete(&tree, &i) == 0);
|
||||
rb_assert(tree.root);
|
||||
|
||||
teardown();
|
||||
}
|
||||
|
|
@ -187,11 +129,9 @@ void test_rbtree_delete_all() {
|
|||
continue;
|
||||
|
||||
assert(rbtree_delete(&tree, &keyref[i]));
|
||||
rb_assert(tree.root);
|
||||
}
|
||||
|
||||
assert(rbtree_is_empty(&tree));
|
||||
rb_assert(tree.root);
|
||||
|
||||
teardown();
|
||||
}
|
||||
|
|
@ -201,7 +141,6 @@ void test_rbtree_walk() {
|
|||
setup(1);
|
||||
|
||||
rbtree_walk(&tree, walk_fn);
|
||||
rb_assert(tree.root);
|
||||
|
||||
teardown();
|
||||
}
|
||||
|
|
@ -214,12 +153,10 @@ void test_rbtree_search() {
|
|||
|
||||
s = keyref[NODES/2];
|
||||
f = rbtree_search(&tree, &s);
|
||||
rb_assert(tree.root);
|
||||
assert(f && *f == s);
|
||||
|
||||
s = MAX_VAL + 512;
|
||||
f = rbtree_search(&tree, &s);
|
||||
rb_assert(tree.root);
|
||||
assert(f == NULL);
|
||||
|
||||
teardown();
|
||||
|
|
|
|||
Reference in a new issue